It is increasingly agreed that ethics has a place in undergraduate medical education. There is, however, debate about how it should be taught, and by whom. We present our experience of teaching ethics in a general practice module over six years. During this period there has been a shift from a teacher-centred to a student-centred approach in which students choose ethical issues to explore within a framework provided. The issues raised are discussed with examples, and the future directions of our ethics teaching outlined.